Fix tablewriter v1.x compatibility in go.mod and update code to use new API#91
Draft
Fix tablewriter v1.x compatibility in go.mod and update code to use new API#91
Conversation
Co-authored-by: timoknapp <11437666+timoknapp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing go.sum entry for tablewriter in PR #89 by running go mod tidy
Fix tablewriter v1.x compatibility in go.mod and update code to use new API
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #89 fails due to a missing go.sum entry for github.com/olekukonko/tablewriter v1.x. Additionally, the code in
pkg/sccli/sccli.gowasn't updated to be compatible with the new tablewriter API in v1.x.Changes Made
This PR resolves the compatibility issues by:
go mod tidyto update go.sum with the correct checksums for tablewriter v1.0.6pkg/sccli/sccli.goto use the new tablewriter API:NewWriter()withNewTable()SetHeader()with theWithHeader()optionTesting
The changes have been tested by:
make build-linuxThis allows the PR #89 to be merged without any further build errors.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
soundcloud.com/tmp/go-build3523993178/b244/soundcloud.test -test.testlogfile=/tmp/go-build3523993178/b244/testlog.txt -test.paniconexit0 -test.gocoverdir=/tmp/go-build3523993178/b244/gocoverdir -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.